Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MenuBar] Make menu start index more consistent. #96507

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Sep 3, 2024

  • Removes unrelated MenuButton links for docs.
  • Adds few extra notes to the docs.
  • Makes start_index work as sort order. Previously MenuBar was using it as an actual index of menu item in the main menu, but since MenuBar can have multiple items and always is a continuous item range it was counterintuitive and hard to use. Now menu is simply added before first menu with the higher or equal start_index (or at the end if it's -1).

@bruvzg bruvzg added this to the 4.4 milestone Sep 3, 2024
@bruvzg bruvzg marked this pull request as ready for review September 4, 2024 07:52
@bruvzg bruvzg requested review from a team as code owners September 4, 2024 07:52
@akien-mga akien-mga merged commit 6815c47 into godotengine:master Sep 6, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants