Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Use the same API for all OS_Windows::*_environment functions. #96526

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Sep 3, 2024

Fixes #96521

@bruvzg bruvzg added this to the 4.4 milestone Sep 3, 2024
@bruvzg bruvzg marked this pull request as ready for review September 4, 2024 07:23
@bruvzg bruvzg requested a review from a team as a code owner September 4, 2024 07:23
@akien-mga akien-mga merged commit 82799d7 into godotengine:master Sep 4, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga added the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Sep 4, 2024
@akien-mga
Copy link
Member

Cherry-picked for 4.3.1.

@akien-mga akien-mga removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OS.get_environment("something") delivers correct value despite OS.has_environment("something") reports false
2 participants