Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation of some ItemList signals #96548

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

timothyqiu
Copy link
Member

  • When mouse position is mentioned, it's better to specify the coordinate system being used.
  • Clarify that item_selected is only applicable in single selection mode. i.e., multi-selecting an item won't emit both item_selected and multi_selected.

@timothyqiu timothyqiu added this to the 4.4 milestone Sep 4, 2024
@timothyqiu timothyqiu requested a review from a team as a code owner September 4, 2024 06:03
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes, but these descriptions smell old. If we really want to change them for the better they could be reworded outright, for example by saying "Emitted", not "Triggered".

@timothyqiu
Copy link
Member Author

Done. Also changed the remaining "Triggered" to "Emitted" since there are just two of them.

@akien-mga akien-mga merged commit 61fce32 into godotengine:master Sep 27, 2024
19 checks passed
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the item-list-signals branch September 27, 2024 11:57
ahxgamma referenced this pull request in ahxgamma/redot-engine Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants