Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor] Prevent duplicate Open in Editor buttons in scene tree dock #96569

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Sep 4, 2024

Duplicate buttons were added when editor description changed

Also works with deleting the button before the check but I think this is a bit cleaner (it also has the benefit of ensuring the button stays in place)

Regression from:

Duplicate buttons were added when editor description changed
@AThousandShips AThousandShips added bug topic:editor regression cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Sep 4, 2024
@AThousandShips AThousandShips added this to the 4.4 milestone Sep 4, 2024
@AThousandShips AThousandShips requested review from a team as code owners September 4, 2024 15:03
Copy link
Contributor

@Hilderin Hilderin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me!!

@akien-mga akien-mga merged commit ddef729 into godotengine:master Sep 5, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@AThousandShips AThousandShips deleted the fix_tree_button branch September 5, 2024 15:58
@AThousandShips
Copy link
Member Author

Thank you!

@akien-mga
Copy link
Member

Cherry-picked for 4.3.1.

@akien-mga akien-mga removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change editor description of a child scene causing multiple open in editor buttons in the Scene tab
3 participants