Fix leak when using audio samples instead of streams #96572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamscott
added
bug
platform:web
topic:porting
topic:audio
cherrypick:4.3
Closed
adamscott
force-pushed
the
fix-samples-leak
branch
from
a632f40 to
d3ddce6
Compare
akien-mga
reviewed
Sep 5, 2024
akien-mga
approved these changes
Sep 5, 2024
|
Thanks! |
|
Cherry-picked for 4.3.1. |
akien-mga
removed
the
cherrypick:4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96068
The issue was caused by the fact that the
Ref<AudioStreamPlayback>deletion fromAudioServer::playback_listwas done in theAudioServer::_mix_step()function. When a stream was replaced, it was tagged to be faded out. And when the fading was done, it was promptly deleted/unreferenced.The thing is that samples never trigger
_mix_step(), thus never clearing those references.I now implemented the deletion in a function that
_mix_step()calls and thatAudioServer::stop_playback_stream()calls too. The later calls it if the stream is stopped, flagged as containing a sample, and that it's reference to the sample isnullptr.