Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shift clicking on Add Sun/Environment to Scene buttons #96582

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

Giganzo
Copy link
Contributor

@Giganzo Giganzo commented Sep 4, 2024

Believe this fixes: #73467
Only tested on Linux

First is a single click, second is shift click.

Screencast_20240905_013752.webm

@Giganzo Giganzo requested a review from a team as a code owner September 4, 2024 23:50
@Calinou Calinou added bug topic:editor regression cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Sep 5, 2024
@Calinou Calinou added this to the 4.4 milestone Sep 5, 2024
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected (Fedora 40 KDE X11), with and without single window mode.

add_both_1.mp4
add_both_2.mp4

@Giganzo Giganzo force-pushed the add-sun-and-env-with-shift branch from b94757c to 1b6af3a Compare September 5, 2024 10:06
@akien-mga akien-mga merged commit 80b1cbb into godotengine:master Sep 5, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@Giganzo Giganzo deleted the add-sun-and-env-with-shift branch September 5, 2024 16:17
@akien-mga
Copy link
Member

Cherry-picked for 4.3.1.

@akien-mga akien-mga removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Sep 16, 2024
@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants