-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Control+Shift+U (rebindable) action for Unicode input, show hex as it is entered. #96592
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally on Fedora 40 KDE X11, there are some issues when you use Shift + home row keys to enter numbers on a French AZERTY (fr-oss) keyboard layout. It remains stuck after you press other keys such as arrow keys:
unicode_input.mp4
Using screenkey to show pressed keys.
This does not occur when using the numpad to enter numbers, as seen at the end of the video above.
Is it supposed to do something until you press Enter/Esc to commit/cancel it? (Video seems to only show static frame with Ctrl+R visible, not sure if it's an issue with recording or Firefox, and downloaded video refuse to open at all). |
For the record, I tested the same feature in Firefox, and it seems to accept the following keys to end the edit mode and process the character:
Ctrl and Shift are maybe a bit far fetched, but in our implementation I'd feel natural for Space to work too. Or we could support the same keys as Firefox for convenience. That being said I see merit in using |
I confirm that with a French keyboard the main number keys can't be used. After pressing Ctrl+Shift+U:
|
The behavior is weird when you move the caret: GR9HB1XCsV.mp4 |
This is a side effect of #87479 (this change seems fine, but I have not accounted for this behavior, the same change probably should be done for
Should work now, both with and w/o Shift (tested on macOS), I forgot there are keyboard layouts with non-primary level numbers.
Changed it to use both |
Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs rebase, and should be good to merge.
Thanks! |
Implements and closes godotengine/godot-proposals#10654
ui_unicode_start
action (set to Control+Shift+U by default) start Unicode hex input (code submitted/canceled byui_text_submit
/ui_cancel
actions).Screen.Recording.2024-09-05.at.18.18.48.mov