-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid bubbling up changed notification when on new item/key of dictionaries to avoid inspector wipeout. #96623
Conversation
I don't know if this is correct. Needs someone to investigate. |
I just remembered why I didn't do it while it was so simple to do. Doing it the easy way like I did makes the copy paste bug to reappear. I'll make a version that fixes both this and not make the copy paste bug reappear during this week-end. Shouldn't too hard but requires a bit more thought then this first attempt. |
In the end I had some time rn so made the PR and here are some small hindsight on the subject. How the bug can happen outside of this scope |
…naries to avoid inspector whipeout.
5fcff71
to
72f4394
Compare
Thanks! |
fix #95647
This fix the issue at hand but first of all I'm not sure this is the right fix second I'm not even sure this property should be exposed in the inspector as it doesn't seem to be the right way to edit it (dedicated interface in the animation bottom panel). In any case this fix is safe so it can be included anyway.