Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Animated Path2D doesn't update PathFollow2D progress when scene is running. #96629

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

ditiem-games
Copy link

@ditiem-games ditiem-games commented Sep 6, 2024

PathFollow2D needs to update its transform whenever a curve changes (for instance a point change its position).

I have tested with the project provided in #85813
bugsquad edit: Fixes #85813.

I have noticed useless code in curve.cpp around call to _bake function:

	if (baked_cache_dirty) {
		_bake();
	}

and the _bake functions is like:

void Curve2D::_bake() const {
	if (!baked_cache_dirty) {
		return;
	}

My eyes bleed but I did not touch it for easy merge :)

@ditiem-games ditiem-games requested a review from a team as a code owner September 6, 2024 00:24
@kleonc kleonc added bug topic:2d cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Sep 6, 2024
@kleonc kleonc added this to the 4.4 milestone Sep 6, 2024
Copy link
Member

@kleonc kleonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@kleonc kleonc requested a review from KoBeWi September 16, 2024 19:59
@Repiteo Repiteo merged commit 66d19ab into godotengine:master Oct 21, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 21, 2024

Thanks!

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release topic:2d
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Animated Path2D doesn't update PathFollow2D progress when scene is running.
6 participants