LSP: Omit some values based on specification version 3.17 #96725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Sep 13, 2024
Seems like it was added like that back in #29780. |
Well given that it isn't deprecated in the spec, I think it is fine to remove the note. We might want to look into moving over to |
|
Thanks! |
akien-mga
added
the
cherrypick:4.3
|
Cherry-picked for 4.3.1. |
akien-mga
removed
the
cherrypick:4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93224 (as confirmed there)
Fixes #47930
As noticed in the issue Godot does pass some empty strings for properties. This was fine based on the LSP spec 3.16 which was worded as When
falsythe label is used. as of version 3.17 this has been reworded to When omitted the label is used so we need to omit empty strings ourself, neovim won't do it for us, if it is based on version 3.17.Also I don't know where the deprecated note on insertText came from, but it isn't in 3.17 nor in the upcoming 3.18.