Add "Use Node Type Suffixes" 3D scene import option #96745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire
approved these changes
Sep 9, 2024
aaronfranke
force-pushed
the
optional-node-name-suffixes
branch
from
e64c3ec to
b0f9909
Compare
aaronfranke
changed the title
Mickeon
approved these changes
Sep 9, 2024
|
Thanks! |
This was referenced Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72419 and fixes #87988 by giving users an option to disable node type suffixes if they are causing undesired behavior. Disabling node type suffixes also makes the editor importer more similar to runtime imports. The default behavior is to be enabled, which is the same behavior as master without this PR. Supersedes PR #83222, PR #39924, and implements proposal godotengine/godot-proposals#1029.
See this article for more information: https://docs.godotengine.org/en/stable/tutorials/assets_pipeline/importing_3d_scenes/node_type_customization.html
Long-term, I would like to get rid of the node name suffix system. I consider it to be a hack. However, we must keep it for now, because the ideal replacements are not ready yet, so users still depend on this. As long as this feature exists, users should be able to choose whether to have it on or off. I wrote more info here: #72419 (comment)