Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MinGW] Fix GCC ar detection. #96747

Merged
merged 1 commit into from
Sep 9, 2024
Merged

[MinGW] Fix GCC ar detection. #96747

merged 1 commit into from
Sep 9, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Sep 9, 2024

Fixes #96736

@bruvzg bruvzg added this to the 4.4 milestone Sep 9, 2024
@bruvzg bruvzg requested a review from a team as a code owner September 9, 2024 07:40
@alvinhochun
Copy link
Contributor

I thought I tested it, but apparently not... (facepalm)
Thanks for fixing.

@akien-mga akien-mga merged commit 9fb54b7 into godotengine:master Sep 9, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mechalynx mechalynx mechalynx left review comments

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug platform:windows topic:buildsystem
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

ar version check in platform/windows/detect.py can fail if there is a patch number
4 participants
@bruvzg @alvinhochun @akien-mga @mechalynx