Fix EditorSpinSlider blocking viewport from getting focus #96786
+5
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
bug
topic:editor
topic:gui
regression
cherrypick:4.3
KoBeWi
approved these changes
Oct 18, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts a part of #93165 to fix #95607 without reintroducing #88102. Supersedes #96660.
Making spin slider a text field was a mistake on our part because it technically isn't one, it has one that appears when it's being edited, which in turn does all focus blocking just fine on its own. This PR instead checks for range in the scene tree dock specifically for the rename shortcut to solve the Enter conflict on macOS