Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metal: Fix out of bounds crash when using debug draw modes #96822

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

stuartcarnie
Copy link
Contributor

Closes #96821 by first checking the index is not UNUSED (0xffffffff), before accessing the vector.

Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Tested locally and confirm that it fixes the crash

@clayjohn clayjohn added this to the 4.4 milestone Sep 10, 2024
@stuartcarnie stuartcarnie changed the title Metal: fix out of bounds crash when using debug draw modes Metal: Fix out of bounds crash when using debug draw modes Sep 10, 2024
@akien-mga akien-mga merged commit 62717f2 into godotengine:master Sep 11, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when using shadow atlas debug modes with Metal renderer
3 participants