Remove useless Viewport::gui.key_input_accepted

[L2750558108]

Viewport::gui.key_input_accepted seems could be replaced by set_input_as_handled and is_input_handled, since all detections gui.key_event_accepted end up being set_input_as_handled

[Sauermann]

I believe, that this simplification is beneficial and that the behavioral changes are very minor, so that nearly no user will not notice these changes.
Please have a look at my other comments, which seem to be easily resolvable.
Also make sure, to squash the commits together as mentioned in the docs: https://docs.godotengine.org/en/latest/contributing/workflow/pr_workflow.html#the-interactive-rebase

[L2750558108]

have a look at my other comments, which seem to be easily resolvable.

Already fixed. Just careless mistakes.

[Sauermann]

I did a code review and these changes make sense to me. I have not tested the PR though.

These changes are beneficial, because they consolidate the different behavior of Viewport.set_input_as_handled() and Control.accept_event(), which could be considered a bug.

While this is a change in behavior, I believe, that it is a minor change, that will not interfere with nearly all users.

Since it touches a core class, this PR would benefit from merging early in the dev cycle to get enough testing.

[L2750558108]

While the Control::accept_event is become the same as Viweport::set_input_as_handled, I want to do some trimmer in this PR by the way. Move Control::accept_event to Node::accept_event. Nodes can receive input events more briefly like accept_event in before Control nodes. This will not lead to compatibility issues.

Resolved

[AThousandShips]

Moving a method up in the hierarchy can be a bit complicated and might need compatibility code, we'll see when CI has finished

[AThousandShips]

You will need to register compatibility methods, see here for instructions

[L2750558108]

Remove Useless Viewport::gui.key_input_accepted

OK. And why the PR's title is changed? Move this method is not the main thing this PR do.

[Sauermann]

My recommendation would be to keep the two changes in two different pull requests.
The removal of Viewport::gui.key_input_accepted is enough of a change for a single pull request.
Since the behavior change could cause irritations with users, debugging or reverting it that way is much cleaner.
Also: the smaller a PR, the easier it is to review.

The change of moving accept_event from Control to Node would need to be discussed and evaluated separately - a proposal for that change could potentially be a good starting point, in order to evaluate if there is sufficient support in the community for that change.

[AThousandShips]

You also need to add to the API validation file

[AThousandShips]

The move is the method is by far the most impactful change of this, it shouldn't be a footnote

Resolved

[Sauermann]

The PR is again in its previous state, that I already had reviewed yesterday.

[akien-mga]

Thanks! And congrats for your first merged Godot contribution 🎉

[L2750558108]

Yay!