[Editor, Servers] Minor optimizations #96875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartcarnie
commented
Sep 11, 2024
| @@ -2246,7 +2246,7 @@ void EditorInspectorArray::_setup() { | |||
| } | |||
| move_vbox->add_child(ae.move_texture_rect); | |||
|
|
|||
| if (element_position < _get_array_count() - 1) { | |||
| if (element_position < count - 1) { | |||
There was a problem hiding this comment.
Counts are cached at the top of the function:
godot/editor/editor_inspector.cpp
Lines 2164 to 2165 in 14a7e0a
stuartcarnie
commented
Sep 11, 2024
stuartcarnie
commented
Sep 11, 2024
There was a problem hiding this comment.
Only perform a single lookup in the hash table
stuartcarnie
commented
Sep 11, 2024
| @@ -150,12 +150,10 @@ void RenderingServerDefault::_draw(bool p_swap_buffers, double frame_step) { | |||
|
|
|||
| double time = frame_profile[i + 1].gpu_msec - frame_profile[i].gpu_msec; | |||
|
|
|||
| if (name[0] != '<' && name[0] != '>') { | |||
There was a problem hiding this comment.
This if was redundant given the earlier check in the loop:
godot/servers/rendering/rendering_server_default.cpp
Lines 147 to 149 in 14a7e0a
stuartcarnie
commented
Sep 11, 2024
Comment on lines
-141
to
-145
| if (!dependency_map.has(p_depends_on)) { | ||
| dependency_map[p_depends_on] = HashSet<RID>(); | ||
| HashSet<RID> *set = dependency_map.getptr(p_depends_on); | ||
| if (set == nullptr) { | ||
| set = &dependency_map.insert(p_depends_on, HashSet<RID>())->value; | ||
| } | ||
| set->insert(p_id); | ||
|
|
||
| dependency_map[p_depends_on].insert(p_id); |
There was a problem hiding this comment.
The improvement removes a hash table lookup, as it calls getptr to the value and only if it is nullptr, does it insert it. Overall this function performs 2 less hash-table lookups per call.
stuartcarnie
force-pushed
the
sgc/small_optimisations
branch
from
1cd642a to
5bc5d7a
Compare
stuartcarnie
force-pushed
the
sgc/small_optimisations
branch
from
5bc5d7a to
5cfacc8
Compare
akien-mga
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR introduces a few minor optimisations to prevent double look-ups in hash tables and removes some redundant checks.