-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix selection box + scrolling in animation editor. #96902
Conversation
You can scroll horizontally by holding Shift. EDIT: |
b30080e
to
86fc8ef
Compare
Updated to fix the issues raised. Regarding the Shift+Mouse scroll thing, I believe this is a feature of the ViewPanner which is attached to the Timeline scrollbox, which also gives other navigation controls like being able to scroll through the timeline by clicking and dragging with the middle mouse button. I modified the behaviour to intentionally 'not' call the panner while the selection box is active due to certain undesired behaviour in the site. Perhaps it might be worth keeping the panner active instead, but modifying its functionality when the selection box is active to disable certain features. Regardless, I still think we need testing with omnidirectional mouse scrolling, but I think it would also still be okay to merge as is since its definitely an improvement on the old behaviour in any capacity. |
Thanks! |
Closes #76819
godot.windows.editor.dev.x86_64_aCj3kuXTnJ.mp4
Attempts to fix this by introducing the following changes:
In theory, it should also work with horizontal scrolling too, but I don't have access to a mouse which can do this. If anyone has access to one (I think most Mac computers have a mouse which can do this), please confirm that this fix also works for horizontal scrolling.