-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make script list default wider, minimum narrower #96909
Make script list default wider, minimum narrower #96909
Conversation
Give more space to the script lists by default, but makes minimum smaller than it was. Unifies script editor and shader editor to use same values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rationale makes sense to me, and code looks good.
Is the mono check failing by some unrelated circumstance? Can I force it to rerun (amend something back and forth and force push the same commit?) |
Thanks! |
@tetrapod00 Sorry I didn't notice your edit. Could you open a separate issue for this so it won't be forgotten? Also check if it's editor specific or ItemList in general. |
Give more space to the script lists by default, but makes minimum smaller than it was. Unifies script editor and shader editor to use same values.
Before
Here's how default&minimum value is in current master on 1080 resolution 100% editor scale:

Script editor: 150 px
Shader editor: 200 px
Note how script editor's list is so narrow that even
new_script.gd(*)
doesn't fit.After
Here's the new default:

Script editor: 200 px
Shader editor: 200 px
Note how code editor is still 115 chars wide, enough for usual code (exceeding 100 chars hampers readability anyway, no matter how big of a monitor).
Here's the new minimum:

Script editor: 100 px
Shader editor: 100 px
As GUI doesn't break (altough it gets cramped), we shouldn't limit the user from customizing layout for small/portrait monitors.
Related: #96865 would benefit from this.