GraphEdit: Improve dotted pattern grid performance #96910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
approved these changes
Sep 12, 2024
zaevi
force-pushed
the
improve_GraphEdit_dot_grid
branch
from
a9aa4ce to
84102af
Compare
|
Just a note for future reference, the batching implementation in #92797 is able to batch rects of differing colors (so it is able to batch the dots even before this PR). But separating the draw calls like this is good practice and may have a performance benefit in the future, so it is worth merging |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate the drawing of major and minor dots so that they can be batched on rendering.
Size = ~2560*1400, Zoom = 42%: