Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add warning about sharing a syntax highlighter to TextEdit #96954

Merged

Conversation

HolonProduction
Copy link
Member

Closes #81419

@akien-mga
Copy link
Member

Makes sense to document, but that sounds a bit counterintuitive to me. What's the point of having SyntaxHighlighter be a Resource, if it can't be shared?

@Mickeon
Copy link
Contributor

Mickeon commented Sep 15, 2024

What's the point of having SyntaxHighlighter be a Resource, if it can't be shared?

I believe it's the same case as TileSetSource & co. which is, indeed, very annoying in practice. Still worth documenting in the hopes that this behavior is fixed someday.

@akien-mga akien-mga force-pushed the highlighter-duplicate-docs branch from 8307739 to 30ad025 Compare September 19, 2024 15:07
@akien-mga akien-mga merged commit 575c321 into godotengine:master Sep 19, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@HolonProduction HolonProduction deleted the highlighter-duplicate-docs branch October 5, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple CodeEdits make infinite loop on request_code_completion()
3 participants