Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose get_export_option_visibility to editor plugins #96980

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Sep 13, 2024

No description provided.

@m4gr3d m4gr3d added this to the 4.4 milestone Sep 13, 2024
@m4gr3d m4gr3d requested a review from dsnopek September 13, 2024 20:57
@m4gr3d m4gr3d requested a review from a team as a code owner September 13, 2024 20:57
@m4gr3d m4gr3d force-pushed the enable_legacy_build_customization_by_plugin branch 2 times, most recently from 852a2f4 to d7d1272 Compare September 18, 2024 12:13
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this is a great idea :-)

I have just a couple notes

@m4gr3d m4gr3d force-pushed the enable_legacy_build_customization_by_plugin branch from d7d1272 to 7a90989 Compare September 29, 2024 22:05
@m4gr3d m4gr3d requested a review from a team as a code owner September 29, 2024 22:05
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest version looks great to me!

@akien-mga akien-mga merged commit 70ac89e into godotengine:master Oct 1, 2024
19 checks passed
@akien-mga
Copy link
Member

Thanks!

@m4gr3d m4gr3d deleted the enable_legacy_build_customization_by_plugin branch October 1, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants