Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "deconstructor" to "destructor" in NOTIFICATION_PREDELETE docs #96981

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

ItzCog
Copy link
Contributor

@ItzCog ItzCog commented Sep 13, 2024

This is probably a bit nitpicky and unnecessary, but as far as I can see, every seemingly reliable sources refer to this concept
as a "destructor" rather than a "deconstructor", including the Wikipedia page title. "Deconstructor" seems very rarely used and is considered incorrect by some.

@ItzCog ItzCog requested a review from a team as a code owner September 13, 2024 21:37
@tetrapod00
Copy link
Contributor

tetrapod00 commented Sep 13, 2024

For additional confirmation, if you search for "deconstructor" in the docs, you get only this single existing result. The same NOTIFICATION_PREDELETE is described as a "destructor" elsewhere, as well.

Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an English speaker object destructor is the way I would describe this concept.

@Chaosus Chaosus added this to the 4.4 milestone Sep 14, 2024
@AThousandShips AThousandShips changed the title Changed "deconstructor" to "destructor" Change "deconstructor" to "destructor" Sep 14, 2024
@akien-mga akien-mga merged commit 330cb45 into godotengine:master Sep 20, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga changed the title Change "deconstructor" to "destructor" Change "deconstructor" to "destructor" in NOTIFICATION_PREDELETE docs Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants