Fix editor_doc_cache locked by adb process on editor startup

[Hilderin]

• Fixes editor_doc_cache errors on editor startup #96798

I was able to reproduce the problem consistently under the following conditions:

• The Godot Editor can be either self-contained or not.
• Android Export needs to be configured in the Editor Settings.
• The project must have an Android Export setup.
• There needs to be an older version of editor_doc_cache-4.4.res in the cache folder:
  • Not self-contained: C:\Users\[user]\AppData\Local\Godot
  • Self-contained: [editorpath]\editor_data\cache
• Start the project. While adb is running, the EditorHelp tries to rewrite the editor_doc_cache-4.4.res on disk and fails.

I tried reproducing the problem by starting adb in a loop in PowerShell and writing to editor_doc_cache-4.4.res in another PowerShell script but was never able to trigger the issue. I also changed the working directory when starting adb.exe in OS_Windows::execute without success. I still don't understand why adb locks this particular file only when started from Godot.

The fix was to postpone the first adb call until after the first scan is completed by adding a check for EditorNode::get_singleton()->is_editor_ready() in EditorExportPlatformAndroid::_check_for_changes_poll_thread. In any case, it wasn't particularly useful to call adb so early, even before the editor is ready.

Here is a small MRP project I used to reproduce the issue:
test-godot-export-android.zip

[m4gr3d]

Thanks for the fix!

This may be a useful pattern to propagate as not all logic need to run on start.

[m4gr3d]

@Hilderin does this fix need to be picked in 4.3?

[Hilderin]

@m4gr3d I'm not sure. Technically, this should probably occurs only dev builds. Once to editor_doc_cache is generated for a Godot version, it does not need to be regenerated. Also, I did not find the source of the issue. It's may be caused by #91902 which is not in 4.3 I think. So, it's your call, the fix should work perfectly in 4.3 but I'm not even sure the problem exists in 4.3.

[m4gr3d]

I've added the pick request; the update is straightforward enough and an improvement to the logic to warrant it.

[akien-mga]

Thanks!

[akien-mga]

Cherry-picked for 4.3.1.