Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FileDialog default size #97004

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Conversation

Giganzo
Copy link
Contributor

@Giganzo Giganzo commented Sep 14, 2024

Fixes: #58780

Before:
Screenshot_20240914_132037

After:
Screenshot_20240914_161601

@Giganzo Giganzo requested a review from a team as a code owner September 14, 2024 15:48
@AThousandShips AThousandShips added bug topic:gui cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Sep 14, 2024
@AThousandShips AThousandShips added this to the 4.4 milestone Sep 14, 2024
@WhalesState
Copy link
Contributor

WhalesState commented Sep 18, 2024

This change should be added to the FileDialog.xml to paypass the checks,
You can open the failed check and copy the line to the same place in the XML file.

The proper way is to use the --doctool from cmd.

path/to/godot-source-code/bin/./godot.exec --doctool path/to/godot-source-code/

If you are using VSCode, you can edit and use this build task.

{
    "label": "build docs",
    "group": "build",
    "type": "shell",
    "command": "${workspaceFolder}/bin/./godot.windows.editor.x86_64.exe --doctool ${workspaceFolder}/"
}

@Giganzo Giganzo requested a review from a team as a code owner September 18, 2024 08:29
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new default size makes the dialog much more usable. I tested and it works correctly with scaling enabled too.

@akien-mga akien-mga removed cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Sep 18, 2024
@akien-mga akien-mga merged commit a80e57c into godotengine:master Sep 18, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@Giganzo Giganzo deleted the file_dialog_size branch September 21, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileDialog appears super-small
5 participants