Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Add DisplayServer flag for sharp corners #97005

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Sep 14, 2024

Inspired by this comment, this PR aims to make the rounded/sharp corners found in Windows 11 a toggleable feature. One benefit of integrating with the existing flag system means that windows have the ability to individually choose whether their corners are rounded. Specifically targets the OS, so it doesn't do anything on embedded subwindows.

@Repiteo Repiteo force-pushed the core/window-corner-style branch from 9b18ab9 to 80c3dcd Compare September 14, 2024 18:08
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on Windows 11 23H2, it works as expected.

This makes more sense as a configurable flag, since non-game applications (and the Godot editor itself) will generally want to keep rounded corners to better fit with other apps on the system.

@Repiteo Repiteo force-pushed the core/window-corner-style branch from 80c3dcd to 52e7d84 Compare September 17, 2024 13:30
@Mickeon
Copy link
Contributor

Mickeon commented Sep 17, 2024

This makes more sense as a configurable flag, since non-game applications (and the Godot editor itself) will generally want to keep rounded corners to better fit with other apps on the system.

Makes you wonder if it should be set to true by default in the Project Settings and/or the Window node itself.

@Calinou
Copy link
Member

Calinou commented Sep 17, 2024

Makes you wonder if it should be set to true by default in the Project Settings and/or the Window node itself.

I'm not sure whether we should intentionally diverge from Windows 11's intended look and feel by default here. It should be the topic of a separate proposal 🙂

@Repiteo
Copy link
Contributor Author

Repiteo commented Sep 17, 2024

I've considered it, but we don't have anything concrete on which users would prefer. We could have a poll sometime between dev3 & release on exactly that, changing the default value if sharp corners are overwhelmingly preferred, but that's obviously outside the scope of this PR.

@Repiteo Repiteo force-pushed the core/window-corner-style branch from 52e7d84 to 94ebd2a Compare September 17, 2024 13:53
@akien-mga akien-mga requested a review from bruvzg September 17, 2024 18:30
@Repiteo Repiteo force-pushed the core/window-corner-style branch from 94ebd2a to f8c4a68 Compare October 18, 2024 16:22
@Repiteo Repiteo modified the milestones: 4.x, 4.4 Oct 18, 2024
@Repiteo Repiteo merged commit 7dbea98 into godotengine:master Oct 21, 2024
21 checks passed
@Repiteo Repiteo deleted the core/window-corner-style branch October 21, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants