-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Add DisplayServer
flag for sharp corners
#97005
Conversation
9b18ab9
to
80c3dcd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally on Windows 11 23H2, it works as expected.
This makes more sense as a configurable flag, since non-game applications (and the Godot editor itself) will generally want to keep rounded corners to better fit with other apps on the system.
80c3dcd
to
52e7d84
Compare
Makes you wonder if it should be set to |
I'm not sure whether we should intentionally diverge from Windows 11's intended look and feel by default here. It should be the topic of a separate proposal 🙂 |
I've considered it, but we don't have anything concrete on which users would prefer. We could have a poll sometime between dev3 & release on exactly that, changing the default value if sharp corners are overwhelmingly preferred, but that's obviously outside the scope of this PR. |
52e7d84
to
94ebd2a
Compare
94ebd2a
to
f8c4a68
Compare
Inspired by this comment, this PR aims to make the rounded/sharp corners found in Windows 11 a toggleable feature. One benefit of integrating with the existing flag system means that windows have the ability to individually choose whether their corners are rounded. Specifically targets the OS, so it doesn't do anything on embedded subwindows.