-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorder C# script properties to fix editor serialization #97014
Reorder C# script properties to fix editor serialization #97014
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested these changes and they fix the linked issue. However, properties exported by overriding _get_property_list
now appear under the base class properties:
4.3.0 | This PR |
---|---|
![]() |
![]() |
But this was also introduced by #93779 and we missed it.
Pushed a fix for this. And I also found when
|
85f7d5a
to
3ca81a3
Compare
That's because in Godot But it would be a more involved fix for a pre-existing issue (#75271), so it can handled in a follow-up PR. |
In this pr, only the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think this is an improvement over what we had before. Thanks!
3ca81a3
to
7df5b78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks! |
Fixes #96983