Fix Viewport Texture must be set to use it #97029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The additional condition has me wonder if it's worth to merge both conditions in a single inline function as they're often repeated. |
Hilderin
force-pushed
the
fix-viewport-texture-must-be-set-to-use-it
branch
from
a0adc4a to
c11107b
Compare
|
I made a separate method to validate and print the error message when the Viewport is on set. |
akien-mga
approved these changes
Sep 18, 2024
akien-mga
added
the
cherrypick:4.3
|
Thanks! |
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the error "Viewport Texture must be set to use it," which is displayed when loading a scene with a
Viewportas a texture.The issue was that the scene had not been loaded when attempting to set the
ViewportTextureto the mesh the first time during scene loading. Checking forvp_changedensures that the errors occurs only when theViewPortis not found.Tested with MRPs from the issue and Godot demo projects:
Procedural Materials
GUI in 3D