Fix AudioStreamMicrophone crash on scene-reload
#97032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
changed the title
AudioStreamMicrophone crash on scene-reload
AThousandShips
added
the
cherrypick:4.3
fire
reviewed
Sep 15, 2024
Comment on lines
+110
to
+118
| #define SAFE_RELEASE(memory) \ | ||
| if ((memory) != nullptr) { \ | ||
| (memory)->Release(); \ | ||
| (memory) = nullptr; \ | ||
| } | ||
|
|
There was a problem hiding this comment.
Are you sure this is the proper way to fix the error?
There was a problem hiding this comment.
This works because .Reset() is failing when ComPtr is NULL.
akien-mga
reviewed
Sep 17, 2024
This comment was marked as resolved.
This comment was marked as resolved.
akien-mga
approved these changes
Sep 17, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #96995: AudioStreamPlayer crashing when stream set to Microphone and autoplay is set to on.