Add a more detailed error message when instantiating a scene with missing export properties #97071
Conversation
AThousandShips
changed the title
|
This must have been the fastest PR review I've ever seen @AThousandShips 🤘 👏👏👏 |
| @@ -527,7 +527,7 @@ Node *SceneState::instantiate(GenEditState p_edit_state) const { | |||
|
|
|||
| bool valid; | |||
| Array array = dnp.base->get(dnp.property, &valid); | |||
| ERR_CONTINUE(!valid); | |||
| ERR_CONTINUE_EDMSG(!valid, vformat("Failed to get property '%s' from node '%s'.", dnp.property, dnp.base->get_name())); | |||
There was a problem hiding this comment.
There's the same code in the Variant::DICTIONARY branch, would be good to use the same better message there too.
There was a problem hiding this comment.
Also just to be clear, the EDMSG variant of the macro means the error will be shown in the editor toaster. Is that what you intended? (i.e. is this an error that the user can trigger from the editor and where it would make sense to show in the toaster and not just in the Output dock?)
There was a problem hiding this comment.
Should I open a separate PR for that?
There was a problem hiding this comment.
No this is exactly the same change as done here, just handling Dictionary and not just Array, so it should be part of the same commit (you can edit it with git commit --amend and git push --force).
akien-mga
added
the
cherrypick:4.3
…ssing export properties.
|
Thanks! |
|
Cherry-picked for 4.3.1. |
akien-mga
removed
the
cherrypick:4.3
As mentioned in the macro of
ERR_CONTINUE, it should only be used when there is no sensible error message.In this case, I was searching for the cause of the ominous error in my project - which were impossible to find without further information.
With this new error message it is much easier as a game dev to understand the problem and fix it.