Speed up lambda capture handling #97087
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
GDScriptLambdaCallable::call
andGDScriptLambdaSelfCallable::call
to usealloca
instead ofVector
when using captures, to avoid extra allocation/copy_on_write calls on each lambda function call.This makes functions like
Array.map
andArray.filter
around 60% faster when using simple lambda functions with captures, compared with gdscript below:Old:
New:
Using
alloca
does require additional stack space, which has a small impact on how many recursive calls can be made whenp_argcount + captures_amount
is large. The first example below (5 captures + 22 arguments) crashes for me at 567 recursive calls with the new code, and at 574 with old code. The second example (1 capture + 4 arguments) crashes at 606 recursive calls in both versions. I think the difference is small enough to be ok, but I can look into avoidingalloca
for larger sizes if needed.