Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Network Profiler not disabling buttons #97101

Conversation

aryan-11825114
Copy link
Contributor

Fixes #96804

Copy link
Member

@Geometror Geometror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, code looks fine (although I have a planned to refactor some parts of the profiler code soon, so it's not that important)
Most likely it was just an oversight from 3.x where this was the behavior of all profilers, but maybe it had a specific reason to be startable before running a scene/the project, so @Faless should give this a look too.

@Faless
Copy link
Collaborator

Faless commented Sep 25, 2024

Most likely it was just an oversight from 3.x where this was the behavior of all profilers, but maybe it had a specific reason to be startable before running a scene/the project, so @Faless should give this a look too.

Before we had the autostart button (#96759) this was the only way to catch all the traffic, including the one at startup.

Now that we have autostart, we don't need to be able to start it manually while disconnected.

Copy link
Collaborator

@Faless Faless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akien-mga akien-mga merged commit 95e7e65 into godotengine:master Sep 25, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@aryan-11825114 aryan-11825114 deleted the fix-network-profiler-not-disabling-buttons branch September 25, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Network Profiler does not disable buttons
4 participants