Fix inconsistency in 3D editor navigation #97104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix typo in orbit/zoom shortcut name - Fix zoom when using trackpad
detomon
commented
Sep 17, 2024
| NavigationMode change_nav_from_shortcut = _get_nav_mode_from_shortcut_check(NAVIGATION_LEFT_MOUSE, shortcut_check_sets, true); | ||
| if (change_nav_from_shortcut != NAVIGATION_NONE) { | ||
| nav_mode = change_nav_from_shortcut; | ||
| for (const ShortcutCheckSet &shortcut_check_set : shortcut_check_sets) { |
There was a problem hiding this comment.
Pan gesture has no mouse button and shortcuts can be empty (e.g., orbit), so _get_nav_mode_from_shortcut_check can't be used here.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #97103. Maybe fixes other inconsistencies with other input methods.