Fix EditorAudioBus corner radius #97113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is extremely subtle but the change makes sense to me. Would increasing the editor's own corner radius in the Editor Settings affect this look as well? |
If you mean interface/theme/corner_radius, yes.
|
Mickeon
approved these changes
Sep 17, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #95410
Don't think the difference between top corner radius on Master an other buses was intended.
In Godot 3 the disabled button style didn't have any corner radius at all. Now in Godot 4 it has for all corners.
Plus in 4.0.alpha13 audio buses had corner radius set for all corners:
Changed the Bus to use BottomPanel style instead of TabContainer
Before:
After:
