Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show project settings starting with underscore #97145

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Sep 18, 2024

If you add a project setting that begins with underscore (e.g. _some_setting, without slashes), it will display under Global category. It's inconsistent with editor settings, which don't show underscored settings. This PR fixes the inconsistency.

@KoBeWi KoBeWi added this to the 4.4 milestone Sep 18, 2024
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@Calinou
Copy link
Member

Calinou commented Sep 18, 2024

It might be worth documenting this fact in the ProjectSettings and EditorSettings class reference, as editor plugins may want to rely on this in specific scenarios.

@KoBeWi
Copy link
Member Author

KoBeWi commented Sep 18, 2024

ProjectSettings have set_as_internal() for hiding properties. This is more relevant when editing project settings without a plugin (which is how I discovered this bug).
EditorSettings have no equivalent method however.

@akien-mga akien-mga merged commit d427a60 into godotengine:master Sep 19, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the supersecretsettings branch September 19, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants