Expose Viewport methods to get current 2D/3D audio listener #97159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mickeon
approved these changes
Sep 18, 2024
aaronfranke
reviewed
Sep 19, 2024
noidexe
force-pushed
the
Expose-viewport-get-audio-listener
branch
from
7f6d54e to
73be914
Compare
aaronfranke
approved these changes
Sep 19, 2024
…er_3d to scripting Document exposed methods Apply suggestions from code review Co-authored-by: Micky <66727710+Mickeon@users.noreply.github.com> Document default behavior when no audio listeners are active
noidexe
force-pushed
the
Expose-viewport-get-audio-listener
branch
from
73be914 to
bdcee83
Compare
|
Thanks! |
KoBeWi
reviewed
Sep 20, 2024
| <method name="get_audio_listener_2d" qualifiers="const"> | ||
| <return type="AudioListener2D" /> | ||
| <description> | ||
| Returns the currently active 2D audio listener. Returns [code]null[/code] if there are no active 2D audio listeners, in which case the active 2D camera will be treated as listener. |
There was a problem hiding this comment.
2D uses viewport transform for positional audio. Unlike 3D, you can hear sounds without any Camera2D in the scene.
Sorry for late review .-.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes the already existing Viewport::get_current_audio_listener_2d and Viewport::get_current_audio_listener_3d methods to scripting, in the same way that get_camera_2d and get_camera_3d are already exposed.
closes #54612