Expose has_undo() and has_redo() of LineEdit
#97167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MewPurPur
force-pushed
the
reveal-undoredo
branch
from
94c9440 to
9252190
Compare
MewPurPur
force-pushed
the
reveal-undoredo
branch
from
9252190 to
5545ab1
Compare
MewPurPur
force-pushed
the
reveal-undoredo
branch
from
5545ab1 to
f7a7ecc
Compare
radiantgurl
approved these changes
Sep 20, 2024
|
I think this might need a more clear name, |
|
It's better to follow the TextEdit convention I think. |
AThousandShips
approved these changes
Sep 20, 2024
akien-mga
approved these changes
Sep 20, 2024
Mickeon
approved these changes
Sep 20, 2024
akien-mga
changed the title
has_undo() and has_redo() of LineEdit
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some progress towards godotengine/godot-proposals#9207.
When using LineEdit, you might want to make a custom context menu or other utility for Undo/Redo. One thing that makes this harder than it needs to be is the inability to easily tell if LineEdits can undo/redo, which makes it impossible to disable their corresponding buttons:
TextEdits already expose this.