Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FileSystemDock's EditorContextMenuPlugins #97185

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Sep 19, 2024

Fixes regression from #65585

Base ID of EditorContextMenuPlugin is greater than CONVERT_BASE_ID, so it should be checked first. Otherwise context menu IDs were recognized as out-of-bounds conversions.

@KoBeWi KoBeWi added this to the 4.4 milestone Sep 19, 2024
@KoBeWi KoBeWi requested a review from a team as a code owner September 19, 2024 13:34
@akien-mga akien-mga merged commit c8d76c1 into godotengine:master Sep 19, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the ID_war branch September 19, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants