Metal: Fix subpixel blending; fix inconsistent blend state #97217
+16
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartcarnie
force-pushed
the
97185_subpixel_rendering
branch
from
6b6eb82 to
e826ab9
Compare
akien-mga
changed the title
akien-mga
changed the title
akien-mga
changed the title
akien-mga
approved these changes
Sep 20, 2024
|
I can confirm that this fixes the blending issue for subpixel antialiasing. |
|
@mihe thanks for confirming 🙇🏻 |
|
Thanks! |
|
Is it fixing #97056 as well? |
Yes, that is the Metal part of the fix in that PR and I observed those symptoms in the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #97195
Note
Investigating this issue identified an unrelated blending issue in Metal, which is also fixed.
has_blendstate, which was incorrectly carried across batches.