Don't list CSV as a valid extension for Translation resource
#97222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Seems good for now, but we really need to change the way we deal with CSV for translations to remove this and many other hacks.
For example .csv files are the only "1 source to multiple Resources" imported files, which also mean that the generated .translation files can't be put in .godot/imported/, because there's no way for load("res://translations.csv") to be remapped to a single resource (as seen in #42392 (comment)).
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #87187
When adding translation files in the Project Settings dialog, a
.csvfile is currently valid choice.CSV is recognized by the resource importer to generate translation files, but it's not a
Translationresource file itself.Also removed an unused header include in the modified source file :P
Note: One drawback is that if someone created a custom importer that does import a CSV file as one valid
Translationresource (which is not very useful), this PR also prevents the user from selecting the file directly. However, the user can still select the file by selecting the "All Files" filter.