Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong displayed category name in EditorHelpSearch #97242

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

timothyqiu
Copy link
Member

The last two parameters of _create_category_item() are passed in the opposite order in actual use, so the dialog currently displays methods (metadata) instead of Methods (text). This PR swaps the two parameters.

Also fixed two typos related to the "Properties" category.

Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this, must have gotten stuck in some refactoring at some point!

@akien-mga akien-mga merged commit cc26cac into godotengine:master Sep 21, 2024
19 checks passed
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the meta-text branch September 21, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants