Windows: Fix dragging and dropping files from compressed files into editor

[Garetonchick]

Fixes #97128.

Use case described by @Maran23 in #97128 (comment) still doesn't work. I can look into it later.

[SaracenOne]

Good job, and congratulations on your first commit! I tested this and it does appear to work in regards to the issue I raised with 7zip. I'll approve this for now, but would you mind squashing the commits from this PR into a single commit? We generally prefer that convention when merging.

[Garetonchick]

Good job, and congratulations on your first commit! I tested this and it does appear to work in regards to the issue I raised with 7zip. I'll approve this for now, but would you mind squashing the commits from this PR into a single commit? We generally prefer that convention when merging.

Thank you! I have squashed the commits.

[bruvzg]

Seems to be working as expected.

Use case described by @Maran23 in #97128 (comment) still doesn't work. I can look into it later.

This likely requires handling CFSTR_FILECONTENTS and CFSTR_FILEDESCRIPTOR in addition to CF_HDROP.

[Garetonchick]

Seems to be working as expected.

Use case described by @Maran23 in #97128 (comment) still doesn't work. I can look into it later.

This likely requires handling CFSTR_FILECONTENTS and CFSTR_FILEDESCRIPTOR in addition to CF_HDROP.

Added handling of CFSTR_FILEDESCRIPTOR and CFSTR_FILECONTENTS as you have suggested. Now drag-and-drop from inside the .zip file from Windows Explorer also works. Also I tested the same case with Total Commander and it works as well.

However, this time I had to do a bit of filesystem manipulations and couldn't find some functinality in Godot's source code. These are: joining filepaths with correct OS separator, creating temporary directory with random name, creating all subdirectories for a path and recursively removing directory with it's contents. For now I have written quick & dirty implementations of these, which are not general purpose, but happen to work here. So I would appreciate it if someone pointed me to the relevant existing functionality. Or if it doesn't exist, it probably should be added (maybe in a separate PR?) for general use.

[Calinou]

Tested locally (rebased on top of master 44fa552), it works as expected on Windows 11 23H2. Nested file structures work correctly, and so do file names containing Unicode characters.

Note that empty folders are not created if you drag a folder that contains empty folders to the Godot editor. (Even if you right-click it and use Show in File Manager, the folders won't be there.)

As mentioned in OP, using 7-zip's GUI (7ZFM.exe) will work, but using Windows Explorer won't. This applies regardless of the compression format.

[bruvzg]

These are: joining filepaths with correct OS separator, creating temporary directory with random name, creating all subdirectories for a path and recursively removing directory with it's contents.

There's DirAccess::erase_contents_recursive, DirAccess::make_dir_recursive and String::path_join (like all other public Godot IO functions, these use / separator, usually conversion is done internally right before passing path to the system API and never exposed to the user, see fix_path in OS_Windows).

godot/platform/windows/os_windows.cpp

Lines 93 to 108 in b3bcb2d

	static String fix_path(const String &p_path) {
	String path = p_path;
	if (p_path.is_relative_path()) {
	Char16String current_dir_name;
	size_t str_len = GetCurrentDirectoryW(0, nullptr);
	current_dir_name.resize(str_len + 1);
	GetCurrentDirectoryW(current_dir_name.size(), (LPWSTR)current_dir_name.ptrw());
	path = String::utf16((const char16_t *)current_dir_name.get_data()).trim_prefix(R"(\\?\)").replace("\\", "/").path_join(path);
	}
	path = path.simplify_path();
	path = path.replace("/", "\\");
	if (path.size() >= MAX_PATH && !path.is_network_share_path() && !path.begins_with(R"(\\?\)")) {
	path = R"(\\?\)" + path;
	}
	return path;
	}

[Repiteo]

Do we want to wait and try to solve that edge-case, or is this ready to merge now in your eyes?

[Garetonchick]

Do we want to wait and try to solve that edge-case, or is this ready to merge now in your eyes?

I think it's okay to merge. This edge case doesn't cause issues on my system (Windows 10), so I can't debug @Calinou's problem on Windows 11. I believe fixing it should be in a separate PR done by someone else.

[Repiteo]

Thanks! Congratulations on your first contribution! 🎉