Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenXR: Correctly set the Depth swapchain name #97259

Merged
merged 1 commit into from
Sep 21, 2024
Merged

OpenXR: Correctly set the Depth swapchain name #97259

merged 1 commit into from
Sep 21, 2024

Conversation

alesliehughes
Copy link
Contributor

Introduced in 08ffa5d.

Though just for debugging, it appears it would report the wrong handle when dealing with the depth swapchain.

dsnopek
dsnopek approved these changes Sep 21, 2024
View reviewed changes
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good catch :-)

@akien-mga akien-mga changed the title openxr: Correctly set the Depth swapchain name OpenXRr: Correctly set the Depth swapchain name Sep 21, 2024
@akien-mga akien-mga changed the title OpenXRr: Correctly set the Depth swapchain name OpenXR: Correctly set the Depth swapchain name Sep 21, 2024
@akien-mga akien-mga added this to the 4.4 milestone Sep 21, 2024
@akien-mga akien-mga merged commit f246419 into godotengine:master Sep 21, 2024
19 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsnopek dsnopek dsnopek approved these changes

Assignees
No one assigned
Labels
bug topic:xr
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@alesliehughes @akien-mga @dsnopek