Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix script editor not underlining Unicode identifiers when Ctrl-hovered #97269

Merged

Conversation

timothyqiu
Copy link
Member

@timothyqiu timothyqiu commented Sep 21, 2024

In addition to the symbol_validate workflow, TextEdit has another layer of restriction that only allows underlining symbols whose first character matches the rules of an ASCII identifier (clicking the symbol works fine though).

Before After
Peek 2024-09-21 14-07 Peek 2024-09-21 14-09

I wonder if this restriction could be lifted. But making it accept Unicode identifiers should be relatively safer.

@timothyqiu timothyqiu added this to the 4.4 milestone Sep 21, 2024
@timothyqiu timothyqiu requested a review from a team as a code owner September 21, 2024 06:18
@akien-mga akien-mga merged commit 2daea4b into godotengine:master Sep 21, 2024
19 checks passed
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the underline-unicode-identifier branch September 21, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants