Avoid duplicating signals from scene instances into packed scenes (reverted) #97303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this also fixes #85372 |
fire
changed the title
AThousandShips
added
cherrypick:4.2
cixil
force-pushed
the
fix-duplicate-signal-bug
branch
from
e0cf91d to
3327ed7
Compare
KoBeWi
reviewed
Oct 28, 2024
KoBeWi
reviewed
Oct 28, 2024
KoBeWi
reviewed
Oct 28, 2024
KoBeWi
reviewed
Oct 28, 2024
KoBeWi
reviewed
Oct 28, 2024
KoBeWi
reviewed
Oct 28, 2024
KoBeWi
approved these changes
Oct 28, 2024
cixil
commented
Oct 28, 2024
AThousandShips
previously requested changes
Oct 29, 2024
|
Thanks for working on this! The error flood from this issue has made it difficult to spot real errors in my project. |
akien-mga
reviewed
Nov 12, 2024
akien-mga
force-pushed
the
fix-duplicate-signal-bug
branch
from
6540f16 to
8a42e3d
Compare
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
This was referenced Dec 9, 2024
akien-mga
changed the title
akien-mga
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: This PR was partially reverted by #100235 so the issues are not fixed. #100965 has been created as a follow up
Fixes #48064 and fixes #86532
When packing a tree of nodes to a
PackedScene, signal connections originating from the root node of a scene instance within that tree would get duplicated into the PackedScene and cause "duplicate signal" errors when instantiating it.