Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Add button style in GroupsEditor #97319

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Fix Add button style in GroupsEditor #97319

merged 1 commit into from
Sep 23, 2024

Conversation

Giganzo
Copy link
Contributor

@Giganzo Giganzo commented Sep 22, 2024

Fixes: #97318

Screencast_20240922_111900.webm

@AThousandShips AThousandShips added this to the 4.4 milestone Sep 22, 2024
@AThousandShips AThousandShips requested a review from a team September 22, 2024 09:57
timothyqiu
timothyqiu approved these changes Sep 22, 2024
View reviewed changes
Copy link
Member

@timothyqiu timothyqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation-wise, this is the right approach to get that add button style.

@akien-mga akien-mga merged commit e3aa152 into godotengine:master Sep 23, 2024
19 checks passed
@akien-mga
Copy link
Member

Thanks!

@Giganzo Giganzo deleted the groups-add-button-style branch November 25, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothyqiu timothyqiu

Assignees
No one assigned
Labels
bug topic:editor usability
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Add Group button style doesn't match Add Child button style
4 participants
@Giganzo @akien-mga @timothyqiu @AThousandShips