Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hash calculation for NTSliceKey #97326

Merged
merged 1 commit into from
Sep 22, 2024
Merged

Fix hash calculation for NTSliceKey #97326

merged 1 commit into from
Sep 22, 2024

Conversation

jj11hh
Copy link
Contributor

@jj11hh jj11hh commented Sep 22, 2024

A bug was introduced from 057367b by adding FSR 2.2.1 support. Which increases hash collision and hurts performance.

@jj11hh
Fix hash calculation for NTSliceKey
864d4fb 
A bug was introduced from 057367b by adding FSR 2.2.1 support.
Which increases hash collision and hurts performance.
@jj11hh jj11hh requested a review from a team as a code owner September 22, 2024 13:10
AThousandShips
AThousandShips approved these changes Sep 22, 2024
View reviewed changes
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple code error

@AThousandShips AThousandShips added bug topic:rendering cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Sep 22, 2024
@AThousandShips AThousandShips added this to the 4.4 milestone Sep 22, 2024
clayjohn
clayjohn approved these changes Sep 22, 2024
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow. That was a bit dangerous. For context, almost all slices of a texture would have the same format override and swizzle. So this would have resulted in a lot of bad duplicate hashes.

@clayjohn clayjohn merged commit 2d6af00 into godotengine:master Sep 22, 2024
19 checks passed
@clayjohn
Copy link
Member

Thank you! And congratulations on having your first PR merged to the Godot repo :)

@Spartan322 Spartan322 mentioned this pull request Jan 22, 2025
Merged
@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release topic:rendering
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@jj11hh @clayjohn @AThousandShips @akien-mga