-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability for PCK patches to remove files #97356
Conversation
6d48e70
to
6accd43
Compare
6accd43
to
7625f10
Compare
At the request of @reduz I've gone ahead and changed this PR to now integrate into the patch creation that was added in #97118. So now if you export a patch and files are found to have been removed since the last export (i.e. with all the patch packs loaded) it will automatically write these new file removal entries to the PCK. I did have to change things around a bit from how they were originally in this PR though:
One benefit of that last point is that the paths stored in the PCK will from now on never include the |
7625f10
to
3385caf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Co-authored-by: Mikael Hermansson <mikael@hermansson.io>
3385caf
to
2ac562c
Compare
Thanks! |
This adds the possibility to add proper directory level diffing to #97118.