Allow passing UID to importer #97363
Conversation
|
Curious, I need to investigate if generates a deterministic uid or merely doesn't repeat because it's from one generator. Also the problems with duplicate uids. |
|
@fire it should be fine, it uses the generator for the base file, then hashes depending on the generated file, so it pretty much is unique. |
| @@ -147,6 +147,9 @@ Error ResourceImporterCSVTranslation::import(const String &p_source_file, const | |||
| if (r_gen_files) { | |||
| r_gen_files->push_back(save_path); | |||
| } | |||
|
|
|||
| ResourceUID::ID save_id = hash64_murmur3_64(translations[i]->get_locale().hash64(), p_source_id); | |||
There was a problem hiding this comment.
Shouldn't we put the path to the hash? I'm wondering if there's two identical translation files, what happens?
There was a problem hiding this comment.
It hashes both the UID of the file and the language, so this should be unique.
There was a problem hiding this comment.
One of the biggest features of uid is that you can relocate the files. so hashing the path would remove that.
There was a problem hiding this comment.
It does not matter, because it uses the base UID for this, which is generated once and then kept if you move it.
It should continue working fine even if you move the file.
This helps, for importers spitting out new resources to the res:// filesystem to actually hash them to generate deterministic UIDs. This PR also fixes the determinism for translations.
akien-mga
force-pushed
the
deterministic-gen-suberesources-id
branch
from
c7ae478 to
fe34c45
Compare
|
Thanks! |
This helps, for importers spitting out new resources to the res:// filesystem to actually hash them to generate deterministic UIDs.
This PR also fixes the determinism for translations.