Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SplitContainer collapsed documentation #97373

Merged

Conversation

kitbdev
Copy link
Contributor

@kitbdev kitbdev commented Sep 23, 2024

Fixed the description of collapsed to be accurate to the existing behavior. It doesn't collapse the first child, it acts as if the split offset it 0, which if the first child is not set to expand looks like it is collapsed.

@kitbdev kitbdev requested a review from a team as a code owner September 23, 2024 17:33
@AThousandShips AThousandShips added bug documentation cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Sep 23, 2024
@AThousandShips AThousandShips added this to the 4.4 milestone Sep 23, 2024
Copy link

@Loff3 Loff3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes it easier to understand 👍

@Repiteo Repiteo merged commit aa6aa45 into godotengine:master Nov 12, 2024
19 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 12, 2024

Thanks!

@kitbdev kitbdev deleted the fix-splitcontainer-collapsed-doc branch November 12, 2024 18:36
@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants