Ensure handle_modes is given default values rather than flagging error if undefined
#97380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…han flagging error
AThousandShips
added
cherrypick:4.2
radiantgurl
approved these changes
Sep 24, 2024
akien-mga
approved these changes
Sep 24, 2024
|
Thanks! |
akien-mga
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66964
Bezier animations weren't being properly converted to from Godot 3.x to 4.x, raising errors such as
Condition "!d.has("handle_modes")" is true. Returning: false. This seems to be because 4.x expected aHandle Modeto be defined for each individual key, whereas in Godot 3.x seems to have the Handle Mode as an Editor setting. When Godot 4.x opened a Godot 3.x project, it looked forhandle_modesthat weren't there, and failed when it couldn't find them. To fix this, I've changed it so that ifhandle_modesis not defined, they are all initialised to 0. (This corresponds toFreeis also the default when creating animations in the Editor)This fix should make it a lot easier to import Bezier animations from Godot 3.x to 4.x.